Add benchmark for adding images to sheet (#367)

* Add benchmark for adding images to sheet

This should help track performance regressions in future changes.

* Only transform sheet name if necessary

.gitignore

@@ -1,2 +1,5 @@
 ~$*.xlsx
 test/Test*.xlsx
+*.out
+test/image3.png
+*.test

picture_test.go

@@ -0,0 +1,20 @@
+package excelize
+
+import (
+	"fmt"
+	_ "image/png"
+	"io/ioutil"
+	"testing"
+)
+
+func BenchmarkAddPictureFromBytes(b *testing.B) {
+	f := NewFile()
+	imgFile, err := ioutil.ReadFile("logo.png")
+	if err != nil {
+		panic("unable to load image for benchmark")
+	}
+	b.ResetTimer()
+	for i := 1; i <= b.N; i++ {
+		f.AddPictureFromBytes("Sheet1", fmt.Sprint("A", i), "", "logo", ".png", imgFile)
+	}
+}

sheet.go

@@ -778,18 +778,20 @@ func (f *File) UnprotectSheet(sheet string) {
 // trimSheetName provides a function to trim invaild characters by given worksheet
 // name.
 func trimSheetName(name string) string {
-	var r []rune
+	if strings.ContainsAny(name, ":\\/?*[]") || utf8.RuneCountInString(name) > 31 {
-	for _, v := range name {
+		r := make([]rune, 0, 31)
-		switch v {
+		for _, v := range name {
-		case 58, 92, 47, 63, 42, 91, 93: // replace :\/?*[]
+			switch v {
-			continue
+			case 58, 92, 47, 63, 42, 91, 93: // replace :\/?*[]
-		default:
+				continue
-			r = append(r, v)
+			default:
+				r = append(r, v)
+			}
+			if len(r) == 31 {
+				break
+			}
 		}
-	}
+		name = string(r)
-	name = string(r)
-	if utf8.RuneCountInString(name) > 31 {
-		name = string([]rune(name)[0:31])
 	}
 	return name
 }