Create replaceservices option for dependency attribute.

pull/81/head
Halil İbrahim Kalkan 9 years ago
parent 6989ff05a5
commit 589b42a20d

@ -5,9 +5,7 @@ using Volo.ExtensionMethods.Collections.Generic;
namespace Volo.Abp.Data.MultiTenancy namespace Volo.Abp.Data.MultiTenancy
{ {
//TODO: Create a replace service registration convention, instead of custom registration in AbpMultiTenancyModule? [Dependency(ReplaceServices = true)]
[DisableConventionalRegistration]
public class MultiTenantConnectionStringResolver : DefaultConnectionStringResolver public class MultiTenantConnectionStringResolver : DefaultConnectionStringResolver
{ {
private readonly IMultiTenancyManager _multiTenancyManager; private readonly IMultiTenancyManager _multiTenancyManager;

@ -1,7 +1,4 @@
using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.DependencyInjection.Extensions;
using Volo.Abp.Data;
using Volo.Abp.Data.MultiTenancy;
using Volo.Abp.Modularity; using Volo.Abp.Modularity;
namespace Volo.Abp.MultiTenancy namespace Volo.Abp.MultiTenancy
@ -10,7 +7,6 @@ namespace Volo.Abp.MultiTenancy
{ {
public override void ConfigureServices(IServiceCollection services) public override void ConfigureServices(IServiceCollection services)
{ {
services.Replace(ServiceDescriptor.Transient<IConnectionStringResolver, MultiTenantConnectionStringResolver>());
services.AddAssemblyOf<AbpMultiTenancyModule>(); services.AddAssemblyOf<AbpMultiTenancyModule>();
} }
} }

@ -28,7 +28,11 @@ namespace Volo.DependencyInjection
{ {
var serviceDescriptor = ServiceDescriptor.Describe(serviceType, type, lifeTime.Value); var serviceDescriptor = ServiceDescriptor.Describe(serviceType, type, lifeTime.Value);
if (dependencyAttribute?.TryRegister == true) if (dependencyAttribute?.ReplaceServices == true)
{
services.Replace(serviceDescriptor);
}
else if (dependencyAttribute?.TryRegister == true)
{ {
services.TryAdd(serviceDescriptor); services.TryAdd(serviceDescriptor);
} }

@ -11,6 +11,8 @@ namespace Volo.DependencyInjection
public virtual bool TryRegister { get; set; } public virtual bool TryRegister { get; set; }
public virtual bool ReplaceServices { get; set; }
public DependencyAttribute() public DependencyAttribute()
{ {

@ -130,6 +130,32 @@ namespace Microsoft.Extensions.DependencyInjection
instances[0].ShouldBeOfType(typeof(FirstImplOfMyService)); instances[0].ShouldBeOfType(typeof(FirstImplOfMyService));
} }
[Fact]
public void Should_Replace_First_Implementation_By_Second_If_Second_Marked_As_ReplaceServices()
{
//Act
_services.AddTypes(typeof(FirstImplOfMyService), typeof(MyServiceReplacesIMyService));
//Assert
//Check descriptons in service collection
var descriptions = _services.Where(s => s.ServiceType == typeof(IMyService)).ToList();
descriptions.Count.ShouldBe(1);
descriptions[0].ImplementationType.ShouldBe(typeof(MyServiceReplacesIMyService));
//Check from service provider
var serviceProvider = _services.BuildServiceProvider();
//Default service should be second one
serviceProvider.GetRequiredService<IMyService>().ShouldBeOfType(typeof(MyServiceReplacesIMyService));
//Should also get all services
var instances = serviceProvider.GetServices<IMyService>().ToList();
instances.Count.ShouldBe(1);
instances[0].ShouldBeOfType(typeof(MyServiceReplacesIMyService));
}
[Fact] [Fact]
public void Should_Not_Register_Classes_Marked_With_DisableConventionalRegistration() public void Should_Not_Register_Classes_Marked_With_DisableConventionalRegistration()
{ {
@ -202,6 +228,12 @@ namespace Microsoft.Extensions.DependencyInjection
public class MyServiceWithExposeList : IMyService1, IMyService2, ITransientDependency public class MyServiceWithExposeList : IMyService1, IMyService2, ITransientDependency
{ {
}
[Dependency(ReplaceServices = true)]
public class MyServiceReplacesIMyService : IMyService
{
} }
public interface IMyService : ITransientDependency public interface IMyService : ITransientDependency

Loading…
Cancel
Save