From 81b43da7b6b5b34f408f0d785a6c798ddd3b6124 Mon Sep 17 00:00:00 2001 From: xuri Date: Wed, 5 Dec 2018 00:27:19 +0800 Subject: [PATCH] Fix comments according to best practices by effective go --- col.go | 2 +- date.go | 2 +- sheet.go | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/col.go b/col.go index 32cda12..8401a99 100644 --- a/col.go +++ b/col.go @@ -337,7 +337,7 @@ func (f *File) RemoveCol(sheet, column string) { f.adjustHelper(sheet, col, -1, -1) } -// Completion column element tags of XML in a sheet. +// completeCol; Completion column element tags of XML in a sheet. func completeCol(xlsx *xlsxWorksheet, row, cell int) { buffer := bytes.Buffer{} for r := range xlsx.SheetData.Row { diff --git a/date.go b/date.go index 45f3040..f52ec59 100644 --- a/date.go +++ b/date.go @@ -90,7 +90,7 @@ func julianDateToGregorianTime(part1, part2 float64) time.Time { return time.Date(year, time.Month(month), day, hours, minutes, seconds, nanoseconds, time.UTC) } -// By this point generations of programmers have repeated the algorithm sent +// doTheFliegelAndVanFlandernAlgorithm; By this point generations of programmers have repeated the algorithm sent // to the editor of "Communications of the ACM" in 1968 (published in CACM, // volume 11, number 10, October 1968, p.657). None of those programmers seems // to have found it necessary to explain the constants or variable names set diff --git a/sheet.go b/sheet.go index 3021946..dbcad2b 100644 --- a/sheet.go +++ b/sheet.go @@ -118,7 +118,7 @@ func trimCell(column []xlsxC) []xlsxC { return col[0:i] } -// Read and update property of contents type of XLSX. +// setContentTypes; Read and update property of contents type of XLSX. func (f *File) setContentTypes(index int) { content := f.contentTypesReader() content.Overrides = append(content.Overrides, xlsxOverride{ @@ -127,7 +127,7 @@ func (f *File) setContentTypes(index int) { }) } -// Update sheet property by given index. +// setSheet; Update sheet property by given index. func (f *File) setSheet(index int, name string) { var xlsx xlsxWorksheet xlsx.Dimension.Ref = "A1" @@ -209,7 +209,7 @@ func (f *File) setAppXML() { f.saveFileList("docProps/app.xml", []byte(templateDocpropsApp)) } -// Some tools that read XLSX files have very strict requirements about the +// replaceRelationshipsNameSpaceBytes; Some tools that read XLSX files have very strict requirements about the // structure of the input XML. In particular both Numbers on the Mac and SAS // dislike inline XML namespace declarations, or namespace prefixes that don't // match the ones that Excel itself uses. This is a problem because the Go XML