Revise some TODOs.

pull/81/head
Halil İbrahim Kalkan 9 years ago
parent 15d34f8062
commit fbd822204b

@ -65,7 +65,6 @@ namespace Volo.Abp.Identity.EntityFrameworkCore
//Split configuration to dedicated classes
//TODO: Set Default Values for properties
builder.Entity<IdentityUser>(b =>
{
b.ToTable("IdentityUsers");

@ -11,7 +11,7 @@ using Volo.ExtensionMethods.Collections.Generic;
namespace Volo.Abp.Identity
{
//TODO: Add Name/Surname/FullName?
//Add Name and Surname properties?
public class IdentityUser : AggregateRoot, IHasConcurrencyStamp
{

@ -329,7 +329,7 @@ namespace Volo.Abp.Identity
if (role == null)
{
throw new InvalidOperationException(string.Format(CultureInfo.CurrentCulture, "Role {0} does not exist.", normalizedRoleName)); //TODO: Localize
throw new InvalidOperationException(string.Format(CultureInfo.CurrentCulture, "Role {0} does not exist!", normalizedRoleName));
}
user.AddRole(_guidGenerator, role.Id);

@ -20,9 +20,8 @@ namespace Volo.Abp.Identity
{
ServiceProvider.GetRequiredService<IdentityRoleManager>();
}
//TODO: Move this service to Volo.Abp.EntityFrameworkCore.Tests since it's actually testing the EF Core repository registration!
[Fact]
[Fact] //Move this test to Volo.Abp.EntityFrameworkCore.Tests since it's actually testing the EF Core repository registration!
public void Should_Resolve_Repositories()
{
(ServiceProvider.GetRequiredService<IIdentityUserRepository>() is EfCoreIdentityUserRepository).ShouldBeTrue();

Loading…
Cancel
Save