Improvements on api versioning.

pull/122/head
Halil İbrahim Kalkan 8 years ago
parent 515bd63f1c
commit a3bd9c8c72

@ -130,7 +130,11 @@ namespace Volo.Abp.Http.Client.DynamicProxying
private ApiVersionInfo GetApiVersionInfo(ActionApiDescriptionModel action)
{
var apiVersion = FindBestApiVersion(action);
var versionParam = action.Parameters.FirstOrDefault(p => p.Name == "apiVersion");
//TODO: Make names configurable!
var versionParam = action.Parameters.FirstOrDefault(p => p.Name == "apiVersion") ??
action.Parameters.FirstOrDefault(p => p.Name == "api-version" && p.BindingSourceId == ParameterBindingSources.Query);
return new ApiVersionInfo(versionParam?.BindingSourceId, apiVersion);
}

@ -84,7 +84,7 @@ namespace Volo.Abp.Http.Client.DynamicProxying
if (apiVersion.ShouldSendInQueryString())
{
AddQueryStringParameter(urlBuilder, isFirstParam, "apiVersion", apiVersion.Version); //TODO: Constant!
AddQueryStringParameter(urlBuilder, isFirstParam, "api-version", apiVersion.Version); //TODO: Constant!
}
}

@ -46,7 +46,8 @@ namespace Volo.Abp.AspNetCore.Mvc.Versioning
options.ReportApiVersions = true;
options.AssumeDefaultVersionWhenUnspecified = true;
options.ApiVersionReader = new QueryStringApiVersionReader("apiVersion");
//options.ApiVersionReader = new UrlSegmentApiVersionReader();
//options.ApiVersionReader = new MediaTypeApiVersionReader();
options.ConfigureAbp(services);
});

Loading…
Cancel
Save