From 58becc59aeacff85c7e4a053c23632705edde07c Mon Sep 17 00:00:00 2001 From: Halil ibrahim Kalkan Date: Tue, 8 Jan 2019 09:53:43 +0300 Subject: [PATCH] Add missing GetCancellationToken calls in repositories --- .../EntityFrameworkCore/EfCoreRepository.cs | 27 ++++++++++++------- .../Repositories/MongoDB/MongoDbRepository.cs | 6 ++--- 2 files changed, 21 insertions(+), 12 deletions(-) diff --git a/framework/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/Domain/Repositories/EntityFrameworkCore/EfCoreRepository.cs b/framework/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/Domain/Repositories/EntityFrameworkCore/EfCoreRepository.cs index acf4d7ce80..23b4e36b75 100644 --- a/framework/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/Domain/Repositories/EntityFrameworkCore/EfCoreRepository.cs +++ b/framework/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/Domain/Repositories/EntityFrameworkCore/EfCoreRepository.cs @@ -86,7 +86,7 @@ namespace Volo.Abp.Domain.Repositories.EntityFrameworkCore if (autoSave) { - await DbContext.SaveChangesAsync(cancellationToken); + await DbContext.SaveChangesAsync(GetCancellationToken(cancellationToken)); } return updatedEntity; @@ -108,7 +108,7 @@ namespace Volo.Abp.Domain.Repositories.EntityFrameworkCore if (autoSave) { - await DbContext.SaveChangesAsync(cancellationToken); + await DbContext.SaveChangesAsync(GetCancellationToken(cancellationToken)); } } @@ -122,8 +122,8 @@ namespace Volo.Abp.Domain.Repositories.EntityFrameworkCore public override async Task> GetListAsync(bool includeDetails = false, CancellationToken cancellationToken = default) { return includeDetails - ? await WithDetails().ToListAsync(cancellationToken) - : await DbSet.ToListAsync(cancellationToken); + ? await WithDetails().ToListAsync(GetCancellationToken(cancellationToken)) + : await DbSet.ToListAsync(GetCancellationToken(cancellationToken)); } public override long GetCount() @@ -133,7 +133,7 @@ namespace Volo.Abp.Domain.Repositories.EntityFrameworkCore public override async Task GetCountAsync(CancellationToken cancellationToken = default) { - return await DbSet.LongCountAsync(cancellationToken); + return await DbSet.LongCountAsync(GetCancellationToken(cancellationToken)); } protected override IQueryable GetQueryable() @@ -153,7 +153,10 @@ namespace Volo.Abp.Domain.Repositories.EntityFrameworkCore public override async Task DeleteAsync(Expression> predicate, bool autoSave = false, CancellationToken cancellationToken = default) { - var entities = await GetQueryable().Where(predicate).ToListAsync(GetCancellationToken(cancellationToken)); + var entities = await GetQueryable() + .Where(predicate) + .ToListAsync(GetCancellationToken(cancellationToken)); + foreach (var entity in entities) { DbSet.Remove(entity); @@ -161,7 +164,7 @@ namespace Volo.Abp.Domain.Repositories.EntityFrameworkCore if (autoSave) { - await DbContext.SaveChangesAsync(cancellationToken); + await DbContext.SaveChangesAsync(GetCancellationToken(cancellationToken)); } } @@ -171,7 +174,10 @@ namespace Volo.Abp.Domain.Repositories.EntityFrameworkCore CancellationToken cancellationToken = default) where TProperty : class { - await DbContext.Entry(entity).Collection(propertyExpression).LoadAsync(GetCancellationToken(cancellationToken)); + await DbContext + .Entry(entity) + .Collection(propertyExpression) + .LoadAsync(GetCancellationToken(cancellationToken)); } public virtual async Task EnsurePropertyLoadedAsync( @@ -180,7 +186,10 @@ namespace Volo.Abp.Domain.Repositories.EntityFrameworkCore CancellationToken cancellationToken = default) where TProperty : class { - await DbContext.Entry(entity).Reference(propertyExpression).LoadAsync(GetCancellationToken(cancellationToken)); + await DbContext + .Entry(entity) + .Reference(propertyExpression) + .LoadAsync(GetCancellationToken(cancellationToken)); } public override IQueryable WithDetails() diff --git a/framework/src/Volo.Abp.MongoDB/Volo/Abp/Domain/Repositories/MongoDB/MongoDbRepository.cs b/framework/src/Volo.Abp.MongoDB/Volo/Abp/Domain/Repositories/MongoDB/MongoDbRepository.cs index 11e79b32e2..194f604847 100644 --- a/framework/src/Volo.Abp.MongoDB/Volo/Abp/Domain/Repositories/MongoDB/MongoDbRepository.cs +++ b/framework/src/Volo.Abp.MongoDB/Volo/Abp/Domain/Repositories/MongoDB/MongoDbRepository.cs @@ -221,7 +221,7 @@ namespace Volo.Abp.Domain.Repositories.MongoDB public override async Task> GetListAsync(bool includeDetails = false, CancellationToken cancellationToken = default) { - return await GetMongoQueryable().ToListAsync(cancellationToken); + return await GetMongoQueryable().ToListAsync(GetCancellationToken(cancellationToken)); } public override long GetCount() @@ -231,7 +231,7 @@ namespace Volo.Abp.Domain.Repositories.MongoDB public override async Task GetCountAsync(CancellationToken cancellationToken = default) { - return await GetMongoQueryable().LongCountAsync(cancellationToken); + return await GetMongoQueryable().LongCountAsync(GetCancellationToken(cancellationToken)); } public override void Delete(Expression> predicate, bool autoSave = false) @@ -257,7 +257,7 @@ namespace Volo.Abp.Domain.Repositories.MongoDB foreach (var entity in entities) { - await DeleteAsync(entity, autoSave, GetCancellationToken(cancellationToken)); + await DeleteAsync(entity, autoSave, cancellationToken); } }