From 40d3f38410b414c3ade8a0cd43aada5fabb5b2de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C4=B0smail=20=C3=87A=C4=9EDA=C5=9E?= Date: Wed, 16 Sep 2020 09:11:28 +0300 Subject: [PATCH] removed max-parallel-builds option --- docs/en/CLI.md | 1 - .../Abp/Cli/Build/DefaultDotNetProjectBuilder.cs | 2 +- .../Volo/Abp/Cli/Build/IDotNetProjectBuilder.cs | 2 +- .../Volo/Abp/Cli/Commands/BuildCommand.cs | 15 --------------- 4 files changed, 2 insertions(+), 18 deletions(-) diff --git a/docs/en/CLI.md b/docs/en/CLI.md index de2b74755d..3053e43880 100644 --- a/docs/en/CLI.md +++ b/docs/en/CLI.md @@ -443,6 +443,5 @@ abp build [options] * ```--working-directory``` or ```-w```: Specifies the working directory. This option is useful when the command is executed outside of a GIT repository or when executing directory doesn't contain a .NET solution file. * ```--build-name``` or ```-n```: Specifies a name for the build. This option is useful when same repository is used for more than one different builds. * ```--dotnet-build-arguments``` or ```-a```: Arguments to pass ```dotnet build``` when building project files. -* ```--max-parallel-builds``` or ```-m```: Max parallel build count when building child projects of a project. * ```--force```: Forces to build projects even they are not changed from the last successful build. diff --git a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Build/DefaultDotNetProjectBuilder.cs b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Build/DefaultDotNetProjectBuilder.cs index a099bb517d..65749fd45c 100644 --- a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Build/DefaultDotNetProjectBuilder.cs +++ b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Build/DefaultDotNetProjectBuilder.cs @@ -9,7 +9,7 @@ namespace Volo.Abp.Cli.Build { public class DefaultDotNetProjectBuilder : IDotNetProjectBuilder, ITransientDependency { - public List Build(List projects, int maxParallelBuildCount, string arguments) + public List Build(List projects, string arguments) { var builtProjects = new ConcurrentBag(); var totalProjectCountToBuild = projects.Count; diff --git a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Build/IDotNetProjectBuilder.cs b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Build/IDotNetProjectBuilder.cs index 46227bb285..02f753c325 100644 --- a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Build/IDotNetProjectBuilder.cs +++ b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Build/IDotNetProjectBuilder.cs @@ -4,6 +4,6 @@ namespace Volo.Abp.Cli.Build { public interface IDotNetProjectBuilder { - List Build(List projects, int maxParallelBuildCount, string arguments); + List Build(List projects, string arguments); } } diff --git a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/BuildCommand.cs b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/BuildCommand.cs index 59a24b20fa..2641273964 100644 --- a/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/BuildCommand.cs +++ b/framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/BuildCommand.cs @@ -35,11 +35,6 @@ namespace Volo.Abp.Cli.Commands Options.WorkingDirectory.Long ); - var maxParallelBuild = commandLineArgs.Options.GetOrNull( - Options.MaxParallelBuild.Short, - Options.MaxParallelBuild.Long - ); - var dotnetBuildArguments = commandLineArgs.Options.GetOrNull( Options.DotnetBuildArguments.Short, Options.DotnetBuildArguments.Long @@ -59,13 +54,9 @@ namespace Volo.Abp.Cli.Commands Console.WriteLine("Finding changed projects..."); var changedProjectFiles = ChangedProjectFinder.Find(buildConfig); - - Console.WriteLine(sw.ElapsedMilliseconds + " ms passed..."); - sw.Restart(); var buildSucceededProjects = DotNetProjectBuilder.Build( changedProjectFiles, - string.IsNullOrEmpty(maxParallelBuild) ? 1 : Convert.ToInt32(maxParallelBuild), dotnetBuildArguments ?? "" ); @@ -118,12 +109,6 @@ namespace Volo.Abp.Cli.Commands public const string Long = "working-directory"; } - public static class MaxParallelBuild - { - public const string Short = "m"; - public const string Long = "max-parallel-builds"; - } - public static class DotnetBuildArguments { public const string Short = "a";