From 2e8e995cf6d8bcb8ea80a39d6c6faf4af03dd850 Mon Sep 17 00:00:00 2001
From: Arman Ozak <arman@armanozak.com>
Date: Wed, 17 Jun 2020 20:02:21 +0300
Subject: [PATCH] test: update breadcrumb specs according to RoutesService

---
 .../breadcrumb/breadcrumb.component.ts        |  2 +-
 .../lib/tests/breadcrumb.component.spec.ts    | 75 ++++++++++---------
 2 files changed, 41 insertions(+), 36 deletions(-)

diff --git a/npm/ng-packs/packages/theme-shared/src/lib/components/breadcrumb/breadcrumb.component.ts b/npm/ng-packs/packages/theme-shared/src/lib/components/breadcrumb/breadcrumb.component.ts
index 4a3b6e12da..4421a864c3 100644
--- a/npm/ng-packs/packages/theme-shared/src/lib/components/breadcrumb/breadcrumb.component.ts
+++ b/npm/ng-packs/packages/theme-shared/src/lib/components/breadcrumb/breadcrumb.component.ts
@@ -41,7 +41,7 @@ export class BreadcrumbComponent implements OnDestroy, OnInit {
 
           while (node.parent) {
             node = node.parent;
-            const { parent, children, ...segment } = node;
+            const { parent, children, isLeaf, ...segment } = node;
             this.segments.unshift(segment);
           }
 
diff --git a/npm/ng-packs/packages/theme-shared/src/lib/tests/breadcrumb.component.spec.ts b/npm/ng-packs/packages/theme-shared/src/lib/tests/breadcrumb.component.spec.ts
index bf93d11188..4ef000a2b1 100644
--- a/npm/ng-packs/packages/theme-shared/src/lib/tests/breadcrumb.component.spec.ts
+++ b/npm/ng-packs/packages/theme-shared/src/lib/tests/breadcrumb.component.spec.ts
@@ -1,63 +1,68 @@
-import { LocalizationPipe } from '@abp/ng.core';
-import { Directive } from '@angular/core';
-import { Router } from '@angular/router';
-import { createComponentFactory, Spectator, SpyObject } from '@ngneat/spectator/jest';
+import { ABP, LocalizationPipe, RouterOutletComponent, RoutesService } from '@abp/ng.core';
+import { RouterModule } from '@angular/router';
+import { createRoutingFactory, SpectatorRouting, SpyObject } from '@ngneat/spectator/jest';
 import { Store } from '@ngxs/store';
 import { BreadcrumbComponent } from '../components/breadcrumb/breadcrumb.component';
 
-@Directive({
-  // tslint:disable-next-line: directive-selector
-  selector: '[routerLink], [routerLinkActive]',
-})
-class DummyRouterLinkDirective {}
+const mockRoutes: ABP.Route[] = [
+  { name: 'Identity', path: '/identity' },
+  { name: 'Users', path: '/identity/users', parentName: 'Identity' },
+];
 
 describe('BreadcrumbComponent', () => {
-  let spectator: Spectator<BreadcrumbComponent>;
+  let spectator: SpectatorRouting<RouterOutletComponent>;
+  let routes: RoutesService;
   let store: SpyObject<Store>;
-  const createComponent = createComponentFactory({
-    component: BreadcrumbComponent,
-    mocks: [Store, Router],
-    imports: [],
-    declarations: [LocalizationPipe, DummyRouterLinkDirective],
+
+  const createRouting = createRoutingFactory({
+    component: RouterOutletComponent,
+    stubsEnabled: false,
     detectChanges: false,
+    mocks: [Store],
+    declarations: [LocalizationPipe, BreadcrumbComponent],
+    imports: [RouterModule],
+    routes: [
+      {
+        path: '',
+        children: [
+          {
+            path: 'identity',
+            children: [
+              {
+                path: 'users',
+                component: BreadcrumbComponent,
+              },
+            ],
+          },
+        ],
+      },
+    ],
   });
 
   beforeEach(() => {
-    spectator = createComponent();
+    spectator = createRouting();
+    routes = spectator.get(RoutesService);
     store = spectator.get(Store);
   });
 
-  it('should display the breadcrumb', () => {
-    const router = spectator.get(Router);
-    (router as any).url = '/identity/users';
-    store.selectSnapshot.mockReturnValueOnce({ LeptonLayoutState: {} });
-    store.selectSnapshot.mockReturnValueOnce({
-      name: 'Identity',
-      children: [{ name: 'Users', path: 'users' }],
-    });
+  it('should display the breadcrumb', async () => {
+    routes.add(mockRoutes);
+    await spectator.router.navigateByUrl('/identity/users');
     // for abpLocalization
     store.selectSnapshot.mockReturnValueOnce('Identity');
     store.selectSnapshot.mockReturnValueOnce('Users');
     spectator.detectChanges();
 
-    expect(spectator.component.segments).toEqual(['Identity', 'Users']);
     const elements = spectator.queryAll('li');
     expect(elements).toHaveLength(3);
     expect(elements[1]).toHaveText('Identity');
     expect(elements[2]).toHaveText('Users');
   });
 
-  it('should not display the breadcrumb', () => {
-    const router = spectator.get(Router);
-    (router as any).url = '/identity/users';
-    spectator.detectChanges();
-    expect(spectator.query('ol.breadcrumb')).toBeFalsy();
-  });
+  it('should not display the breadcrumb when empty', async () => {
+    routes.add([]);
+    await spectator.router.navigateByUrl('/identity/users');
 
-  it('should not display the breadcrumb when abp route not found', () => {
-    const router = spectator.get(Router);
-    (router as any).url = '/identity/users';
-    store.selectSnapshot.mockReturnValueOnce({ LeptonLayoutState: {} });
     spectator.detectChanges();
     expect(spectator.query('ol.breadcrumb')).toBeFalsy();
   });