From bb2ab5ff68de4b5f675b50d22dd553ef597290f0 Mon Sep 17 00:00:00 2001 From: Sinan997 Date: Mon, 16 Oct 2023 22:40:00 +0300 Subject: [PATCH 1/2] fix null return problem in executeErrorHandle method --- .../packages/theme-shared/src/lib/handlers/error.handler.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/npm/ng-packs/packages/theme-shared/src/lib/handlers/error.handler.ts b/npm/ng-packs/packages/theme-shared/src/lib/handlers/error.handler.ts index 0a472a18cb..b61568f136 100644 --- a/npm/ng-packs/packages/theme-shared/src/lib/handlers/error.handler.ts +++ b/npm/ng-packs/packages/theme-shared/src/lib/handlers/error.handler.ts @@ -47,8 +47,7 @@ export class ErrorHandler { return (isObservable ? errHandler : of(null)).pipe( catchError(err => { - this.handleError(err); - return of(null); + return of(err); }), ); }; From 896c98077b9b3a180f41e5bc5b7694a5d003a47b Mon Sep 17 00:00:00 2001 From: Sinan997 Date: Tue, 17 Oct 2023 10:21:53 +0300 Subject: [PATCH 2/2] update executeErrorHandler --- .../packages/theme-shared/src/lib/handlers/error.handler.ts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/npm/ng-packs/packages/theme-shared/src/lib/handlers/error.handler.ts b/npm/ng-packs/packages/theme-shared/src/lib/handlers/error.handler.ts index b61568f136..480a647bbe 100644 --- a/npm/ng-packs/packages/theme-shared/src/lib/handlers/error.handler.ts +++ b/npm/ng-packs/packages/theme-shared/src/lib/handlers/error.handler.ts @@ -45,11 +45,7 @@ export class ErrorHandler { const errHandler = this.httpErrorHandler(this.injector, error); const isObservable = errHandler instanceof Observable; - return (isObservable ? errHandler : of(null)).pipe( - catchError(err => { - return of(err); - }), - ); + return (isObservable ? errHandler : of(null)).pipe(catchError(err => of(err))); }; protected sortHttpErrorHandlers(