Tag helpers small refactoring

8 years ago · 12cd09e347
parent 2749fcf2c2
commit 12cd09e347
4 changed files with 6 additions and 19 deletions
--- a/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Nav/AbpNavItemTagHelperService.cs
+++ b/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Nav/AbpNavItemTagHelperService.cs
@ -14,7 +14,6 @@ namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Nav
            SetActiveClass(context, output);
        }

-
        protected virtual void SetDropdownClass(TagHelperContext context, TagHelperOutput output)
        {
            if (TagHelper.Dropdown ?? false)
--- a/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Nav/AbpNavLinkTagHelperService.cs
+++ b/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Nav/AbpNavLinkTagHelperService.cs
@ -8,14 +8,7 @@ namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Nav
 {
    public class AbpNavLinkTagHelperService : AbpTagHelperService<AbpNavLinkTagHelper>
    {
-        private readonly HtmlEncoder _encoder;
-
-        public AbpNavLinkTagHelperService(HtmlEncoder encoder)
-        {
-            _encoder = encoder;
-        }
-
-        public override async Task ProcessAsync(TagHelperContext context, TagHelperOutput output)
+        public override void Process(TagHelperContext context, TagHelperOutput output)
        {
            output.TagName = "a";
            output.TagMode = TagMode.StartTagAndEndTag;
--- a/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Nav/AbpNavbarNavTagHelperService.cs
+++ b/src/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap/TagHelpers/Nav/AbpNavbarNavTagHelperService.cs
@ -9,7 +9,6 @@ namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.TagHelpers.Nav
        {
            output.TagName = "ul";
            output.Attributes.AddClass("navbar-nav");
-            output.Attributes.AddClass("mr-auto");
        }
    }
 }
--- a/test/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.Demo/Pages/Components/Navs.cshtml
+++ b/test/Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.Demo/Pages/Components/Navs.cshtml
@ -80,13 +80,11 @@
                    <abp-nav-item>
                        <a abp-nav-link disabled="true" href="#">Disabled</a>
                    </abp-nav-item>
+                    <span abp-navbar-text>
+                        Sample Text
+                    </span>
                </abp-navbar-nav>
            </abp-navbar-toggle>
-            
-            <span abp-navbar-text>
-                 Sample Text
-            </span>
-
        </abp-nav-bar>

    </div>
@ -118,13 +116,11 @@
                    &lt;abp-nav-item&gt;
                        &lt;a abp-nav-link disabled=&quot;true&quot; href=&quot;#&quot;&gt;Disabled&lt;/a&gt;
                    &lt;/abp-nav-item&gt;
-                &lt;/abp-navbar-nav&gt;
-            &lt;/abp-navbar-toggle&gt;
-            
+                &lt;/abp-navbar-nav&gt;            
            &lt;span abp-navbar-text&gt;
                 Sample Text
            &lt;/span&gt;
-
+            &lt;/abp-navbar-toggle&gt;
        &lt;/abp-nav-bar&gt;
 </pre>
    </div>